Fix web datepicker text field illegal input crash #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eymar
reviewed
May 23, 2024
...l3/material3/src/skikoMain/kotlin/androidx/compose/material3/KotlinxDatetimeCalendarModel.kt
Outdated
Show resolved
Hide resolved
|
Do you known why iOS CI runs here instead of web? |
it seems that iOS tests run for all changes, regardless of the where the change was added. |
Expensive macos runners aren't happy about that 😆 |
|
anyway, in this case skikoTest was changed and the library version was updated, so it would make sense for iOS tests to run. And ideally to pass... But, CI doesn't want to generate the test report :D |
eymar
approved these changes
May 23, 2024
MatkovIvan
pushed a commit
that referenced
this pull request
May 29, 2024
- Update kotlinx.datetime to [0.6.0](https://github.com/Kotlin/kotlinx-datetime/releases/tag/v0.6.0) - Migrate locale-invariant web formatting/parsing to kotlinx.datetime - Catch parsing exceptions <!-- Optional --> Fixes JetBrains/compose-multiplatform#4856 ## Testing `KotlinxDatetimeCalendarModelTest.illegalDateParsingDoesNotThrowException` <!-- Optional --> This should be tested by QA ## Release Notes ### Fixes - Web - Fixed crash when date picker text field receives illegal input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JetBrains/compose-multiplatform#4856
Testing
KotlinxDatetimeCalendarModelTest.illegalDateParsingDoesNotThrowExceptionThis should be tested by QA
Release Notes
Fixes - Web