Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SkiaLayer transform #422

Merged
merged 9 commits into from
Mar 10, 2023
Merged

Conversation

MatkovIvan
Copy link
Member

Proposed Changes

Proper calculation of transformation matrix in SkiaLayer. Now it matches android implementation.

Testing

Test: Compare result of applying graphicsLayer parameters (rotation* and cameraDistance) between android and desktop.

Please note that 2 tests are failing because golden images need to be updated. TODO

Issues Fixed

Fixes JetBrains/compose-multiplatform#12
Fixes JetBrains/compose-multiplatform#1129

Copy link

@dima-avdeev-jb dima-avdeev-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That's amazing math work.
Added some comments to clarify my understanding.

…m/SkiaLayer.skiko.kt

Co-authored-by: dima.avdeev <99798741+dima-avdeev-jb@users.noreply.github.com>
Copy link
Collaborator

@igordmn igordmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@igordmn igordmn removed the request for review from eymar March 6, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants