Properly detect content based text direction on native #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
force-pushed
the
ivan.matkov/rtl-detection
branch
from
94055a4
to
e40dbe0
Compare
compose/ui/ui-text/src/desktopMain/kotlin/androidx/compose/ui/text/CharHelpers.jvm.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/CharHelpers.skiko.kt
Show resolved
Hide resolved
...text/src/skikoMain/kotlin/androidx/compose/ui/text/platform/SkiaParagraphIntrinsics.skiko.kt
Outdated
Show resolved
Hide resolved
eymar
reviewed
Apr 20, 2023
...text/src/skikoMain/kotlin/androidx/compose/ui/text/platform/SkiaParagraphIntrinsics.skiko.kt
Outdated
Show resolved
Hide resolved
eymar
approved these changes
Apr 20, 2023
|
eymar
pushed a commit
that referenced
this pull request
May 25, 2023
This allows paging playground to resolve compose deps. Test: cd paging && ./gradlew bOS Change-Id: I01d3774eefef7fab1380040a00bb840afa245903 This is an imported pull request from androidx#514. Resolves #514 Github-Pr-Head-Sha: 0d8e2e9 GitOrigin-RevId: bcbbfc2 Change-Id: If61bbef2c6498a6e94ccaf62c77cc3011ff566d7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Testing
Test: More tests TBD
Issues Fixed
Fixes: JetBrains/compose-multiplatform#2875