Fix awaitDragStartOnSlop to detect slop-passing on both axes. #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igordmn
pushed a commit
that referenced
this pull request
Jul 18, 2023
This fixes AIDL failure in core playground Test: ./gradlew :core:core:checkReleaseAidlApiRelease Change-Id: I38614339310c8031995f2e412ce6084f43a0614b This is an imported pull request from androidx#534. Resolves #534 Github-Pr-Head-Sha: 249f03e GitOrigin-RevId: 9dd8c41 Change-Id: I0051520ed18b15b3e4e64820b33b8782aecb2078
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Pass
triggerOnMainAxisSlop = falsetoawaitPointerSlopOrCancellationso that it detects slop-passing on both axes.Testing
Test: Added new unit tests to test vertical-only and horizontal-only dragging.
Issues Fixed
Fixes: JetBrains/compose-multiplatform#3108