iOS default fonts mapping #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eymar
pushed a commit
that referenced
this pull request
Jun 6, 2023
We are hitting b/285039694 on github. Even though we can workaround it, the workaround is adding a dependency on core-ktx from the samples project, which is not a great solution (it needs prebuilt, not module). Bug: 285039694 Test: Github CI This is an imported pull request from androidx#552. Resolves #552 Github-Pr-Head-Sha: 4b7f9d4 GitOrigin-RevId: 4a724fc Change-Id: Ie9762beb99d37427b83c777b08d3dcae533910cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Testing
Test: Run mpp demo, look at new FontFamilies page
Issues Fixed
Fixes JetBrains/compose-multiplatform#2874
Fixes (partially) JetBrains/compose-multiplatform#2985 (TODO: revisit windows fonts)