Fix incorrect Skiko render target on iOS Metal. #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dima-avdeev-jb
approved these changes
May 9, 2023
Co-authored-by: dima.avdeev <99798741+dima-avdeev-jb@users.noreply.github.com>
MatkovIvan
reviewed
May 9, 2023
| @@ -0,0 +1,22 @@ | |||
| # Script to regenerate xcode project | |||
There was a problem hiding this comment.
Should we add copyright here?
| # make script folder current or exit | ||
| cd "$(dirname "$0")" || exit | ||
|
|
||
| if command -v xcodegen >/dev/null 2>&1; then |
There was a problem hiding this comment.
It's better to revert such checks to avoid extra indents of the main logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Since this bug was caused by incorrect SkikoUIView size, we can just use NSLayoutConstraints instead of autoresize mask to constrain SkikoUIView size to ComposeWindow.view.
Testing
Test: launch from within Xcode. Click on M(Metal) debugger.
Select Scope to be Metal GPU and count to 2, click capture. Scroll or trigger redraw in any other way. Investigate command buffers and check that render targets are of expected size.
Issues Fixed
Fixes: incorrect Skiko render target on iOS Metal.
Before:
After:
