Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing getAndIncrement in AtomicLong implementation for web #570

Merged
merged 1 commit into from May 17, 2023

Conversation

eymar
Copy link
Collaborator

@eymar eymar commented May 17, 2023

This implementation (actual for web target - jsWasmMain sourceset) is not supposed to be used in multi-threaded environment.

@eymar
Copy link
Collaborator Author

eymar commented May 17, 2023

Since it's a trivial change, I simply merge but leave your questions/suggestions if you have any.

@eymar eymar requested a review from MatkovIvan May 17, 2023 12:21
@eymar eymar merged commit 40b7ee1 into jb-main May 17, 2023
1 of 2 checks passed
@eymar eymar deleted the web-add-atomic-long-impl branch May 17, 2023 12:21
Copy link
Member

@MatkovIvan MatkovIvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation is OK for single-thread JS env, but I guess it worth to mention in comments to this class that this is not Atomic in general terms.

igordmn pushed a commit that referenced this pull request Jul 10, 2023
Currently due to the typo, generated documentation doesn't contain package description.
See: https://developer.android.com/reference/kotlin/androidx/compose/animation/graphics/res/package-summary

Test: See new generated [documentation page](https://developer.android.com/reference/kotlin/androidx/compose/animation/graphics/res/package-summary)
Fixes: -

This is an imported pull request from androidx#570.

Resolves #570
Github-Pr-Head-Sha: df52f40
GitOrigin-RevId: 62b121a
Change-Id: I1c07bc26ad92cad75581dc26cf863ddc6c4dc3ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants