Wait until compose is idle before returning from DesktopTestOwner.getRoots() #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eymar
approved these changes
Jun 1, 2023
igordmn
approved these changes
Jun 2, 2023
m-sasha
force-pushed
the
m-sasha/sync-main-test-and-frame-clocks
branch
from
b9fdfe4
to
072667c
Compare
m-sasha
force-pushed
the
m-sasha/wait-for-idle-when-getting-test-roots
branch
from
1d3e287
to
388c66c
Compare
Base automatically changed from
m-sasha/sync-main-test-and-frame-clocks
to
m-sasha/test-framework
June 3, 2023 12:06
m-sasha
force-pushed
the
m-sasha/wait-for-idle-when-getting-test-roots
branch
from
388c66c
to
3d8c570
Compare
m-sasha
added a commit
that referenced
this pull request
Jun 11, 2023
m-sasha
added a commit
that referenced
this pull request
Jun 13, 2023
m-sasha
added a commit
that referenced
this pull request
Jun 26, 2023
m-sasha
added a commit
that referenced
this pull request
Jul 3, 2023
eymar
pushed a commit
that referenced
this pull request
Aug 16, 2023
This allows automatically assigning the correct owner for biometric to PRs on GitHub. Test: GH CODEOWNERS Lint Change-Id: Ifaa78b7300a5b523d229e96a05e8ece4e16c2441 This is an imported pull request from androidx#588. Resolves #588 Github-Pr-Head-Sha: 7a31cbc GitOrigin-RevId: 449e8fa Change-Id: I04c1c0b54da48d0d48f643622dad8bb0b372c895
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Run
waitUntilIdleinDesktopTestOwner.getRoots(), as expected by its contract (documented inTestOwner.getRoots()). This makes tests wait until compose is idle when obtaining any semantic node interactions (onNodeand such), as expected.Testing
Test: Added a unit test.