Introduce ComposePanel that can be disposed manually

[Walingar]

Proposed Changes

Current implementation of ComposePanel disposes Compose content on each detach from Swing hierarchy. But for some cases (like toolwindows in IntelliJ) it doesn't work well, since state getting lost. This state can be controlled only externally. For example, in IntelliJ Disposable is used for that.

This PR adds the ComposePanel.isDisposeOnRemove property. By default, it is true. If it is false, the Compose state will be preserved when the ComposePanel is removed from the UI hierarchy. In this case, the Compose state must be controlled by developers - they must call ComposePanel.dispose() manually.

Testing

Test: run introduced test

Issues Fixed

No issues related to this PR

[m-sasha]

Just as an alternative option, you could put a dispose method in ``ComposePanel and add a disposeWhenRemoved flag to the constructor (and/or a setter). This way you could avoid inheritance.

[Walingar]

We discussed this flag with @igordmn and decided that flag that controls behavior is much worse than inheritance

[igordmn]

We discussed this flag with @igordmn and decided that flag that controls behavior is much worse than inheritance

From another PR:

Robert C. Martin's Clean Code Tip 12: Eliminate Boolean Arguments
Boolean arguments loudly declare that the function does more than one thing. They are confusing and should be eliminated.

[m-sasha]

I'm not a big believer in "experts" and their generic advice.
Anyway, it doesn't have to go into the constructor, it can just be a setter/getter. Declaring (and exposing!) an additional class to vary a single behavior seems too much.

But anyway, I'm just suggesting...

[Walingar]

My thought was to have smth like this, so this boolean param it not exposed. It is used internally and only inside removeNotify

class ComposePanel internal constructor(
    private val skiaLayerAnalytics: SkiaLayerAnalytics,
    private val autoDisposable: Boolean,
) : JLayeredPane() {
  @ExperimentalComposeUiApi
  constructor(
      panelScope: CoroutineScope,
      skiaLayerAnalytics: SkiaLayerAnalytics = SkiaLayerAnalytics.Empty
  ) : this(skiaLayerAnalytics, autoDisposable = false) {
      panelScope.launch {
          try {
              awaitCancellation()
          } finally {
              dispose()
          }
      }
  }

[m-sasha]

Also, we have enabled flags in a bunch of composables... We don't do 'DisabledTextField`.

[Walingar]

Honestly, choosing from these two, I would choose a boolean flag here