Lost pointer event fix #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igordmn
approved these changes
Jul 7, 2023
Walingar
pushed a commit
to Walingar/androidx
that referenced
this pull request
Jul 11, 2023
* Add repro case and debug info. * Fix null pressOwner * Revert "Add repro case and debug info." This reverts commit 95bf64a.
mazunin-v-jb
pushed a commit
that referenced
this pull request
Jul 11, 2023
* Add repro case and debug info. * Fix null pressOwner * Revert "Add repro case and debug info." This reverts commit 95bf64a.
eymar
pushed a commit
that referenced
this pull request
Nov 16, 2023
Different version of annotations was being pulled in for the integration test app vs its instrumented tests, which was causing them to fail to build with: GradleException: Cannot find a version of 'androidx.annotation:annotation' that satisfies the version constraints:... Test: cd paging && ./gradlew bOS Change-Id: Ibb3339315975caab0ac5b7734400e8e13602aa36 This is an imported pull request from androidx#623. Resolves #623 Github-Pr-Head-Sha: d3c02ac GitOrigin-RevId: 8c9da25 Change-Id: I35474c1722141f23b74f4ed06e13357dbb1c7f80
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Don't set pressOwner to null while any touch is down.
Testing
Test: try to reproduce fixed bug.
Issues Fixed
Fixes: JetBrains/compose-multiplatform#3310