Fix ScrollConfig in web target (#569) #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix ScrollConfig for web apps Now it makes the tests pass while looking fine in UI. * Enable isSmoothScrollingEnabled for web ScrollConfig * Update compose/foundation/foundation/src/jsWasmMain/kotlin/androidx/compose/foundation/gestures/JsScrollable.js.kt Co-authored-by: Ivan Matkov <ivan.matkov@jetbrains.com> * remove redundant imports * Simplify the fun calculateMouseWheelScroll body --------- Co-authored-by: Ivan Matkov <ivan.matkov@jetbrains.com>
dima-avdeev-jb
approved these changes
Jul 7, 2023
Walingar
pushed a commit
to Walingar/androidx
that referenced
this pull request
Jul 11, 2023
* Fix ScrollConfig for web apps Now it makes the tests pass while looking fine in UI. * Enable isSmoothScrollingEnabled for web ScrollConfig * Update compose/foundation/foundation/src/jsWasmMain/kotlin/androidx/compose/foundation/gestures/JsScrollable.js.kt * remove redundant imports * Simplify the fun calculateMouseWheelScroll body --------- Co-authored-by: Ivan Matkov <ivan.matkov@jetbrains.com>
mazunin-v-jb
pushed a commit
that referenced
this pull request
Jul 11, 2023
* Fix ScrollConfig for web apps Now it makes the tests pass while looking fine in UI. * Enable isSmoothScrollingEnabled for web ScrollConfig * Update compose/foundation/foundation/src/jsWasmMain/kotlin/androidx/compose/foundation/gestures/JsScrollable.js.kt * remove redundant imports * Simplify the fun calculateMouseWheelScroll body --------- Co-authored-by: Ivan Matkov <ivan.matkov@jetbrains.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR "upstreams" the change #569 from wasm-main branch.
It passes the
scrollDeltafromSkikoPointerEventto compose pointer event.The scroll will be animated same as on desktop - it looks more smooth.