Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multi-owner input processing #634

Merged
merged 2 commits into from Jul 12, 2023
Merged

Fix multi-owner input processing #634

merged 2 commits into from Jul 12, 2023

Conversation

MatkovIvan
Copy link
Member

Proposed Changes

Extract scene fixes from #611 into separate PR

  • Separate focusable and dismissOnClickOutside logic
  • Fix click outside logic for multiple owners (now it matches with android)
  • Block all pointer events if it's under focusedOwner

Testing

Test: run tests from DesktopPopupTest or play with multiple Popups

@MatkovIvan
Copy link
Member Author

Since we all agree that we have a room for improvements later and there are no blockers here - I'm merging it as is

@MatkovIvan MatkovIvan merged commit dc621c1 into jb-main Jul 12, 2023
2 checks passed
@MatkovIvan MatkovIvan deleted the ivan.matkov/fix-multi-owner-input branch July 12, 2023 07:23
@MatkovIvan MatkovIvan mentioned this pull request Jul 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igordmn igordmn igordmn approved these changes

@dima-avdeev-jb dima-avdeev-jb dima-avdeev-jb approved these changes

@m-sasha m-sasha Awaiting requested review from m-sasha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@MatkovIvan @igordmn @dima-avdeev-jb