Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sending touches in SkikoInputDispatcher #688

Merged
merged 3 commits into from Jul 18, 2023
Merged

Fix sending touches in SkikoInputDispatcher #688

merged 3 commits into from Jul 18, 2023

Conversation

MatkovIvan
Copy link
Member

@MatkovIvan MatkovIvan commented Jul 18, 2023 •
edited

Proposed Changes

Currently SkikoInputDispatcher uses incorrect overload to send touch events from tests. It leads missing changes data in events and possible incorrect behaviour like tracking currently "pressed" pointers.

  • Fixes handling touch gestures in Popup

Testing

Test: run ComposeUiSkikoTestTest

Issues Fixed

Fixes touch_press_multiple test after locking Release event to pressOwner. See #685

@MatkovIvan MatkovIvan requested a review from igordmn July 18, 2023 14:57
@igordmn igordmn mentioned this pull request Jul 18, 2023
Merged
@MatkovIvan MatkovIvan force-pushed the ivan.matkov/fix-input-dispatcher branch from f03b2ed to 70784b6 Compare July 18, 2023 20:23
@MatkovIvan
Copy link
Member Author

Rebased to jb-main and reverted @Ignore for test

@MatkovIvan MatkovIvan merged commit dcb967b into jb-main Jul 18, 2023
@MatkovIvan MatkovIvan deleted the ivan.matkov/fix-input-dispatcher branch July 18, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-sasha m-sasha m-sasha approved these changes

@igordmn igordmn igordmn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@MatkovIvan @m-sasha @igordmn