Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hover and dismissOnClickOutside handling #691

Closed
wants to merge 8 commits into from

Conversation

MatkovIvan
Copy link
Member

@MatkovIvan MatkovIvan commented Jul 19, 2023

Proposed Changes

It's remaining part of #674 with a few additions

  • Do not override pressOwner on second simultaneous Press event (second touch or second button);
  • Update hover state (send Enter/Exit events) on Release event. It allows to send missing event if updating during Move was blocked by pressOwner;
  • Replace onClickOutside to onOutsidePointerEvent to allow specify filtering by event type or by specific mouse button;
  • Dismiss Popup and Dialog only on mouse primary button click;
  • Dismiss Dialog on Release instead of Press event;

Testing

Test: run tests from PopupTest and DialogTest

Issues Fixed

Fixes JetBrains/compose-multiplatform#3349

@MatkovIvan MatkovIvan force-pushed the ivan.matkov/fix-hover-input branch 2 times, most recently from 77f4f37 to ed9710b Compare July 19, 2023 13:35
@MatkovIvan MatkovIvan marked this pull request as ready for review July 19, 2023 14:48
@MatkovIvan
Copy link
Member Author

Let's split it once again to make review easier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant