Add semantic properties to DialogWindow, Popup and Dialog #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
reviewed
Jul 20, 2023
compose/ui/ui-test-junit4/src/desktopTest/kotlin/androidx/compose/ui/test/FiltersTest.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui-test-junit4/src/desktopTest/kotlin/androidx/compose/ui/test/FiltersTest.kt
Show resolved
Hide resolved
| @@ -51,7 +51,7 @@ class TextActionsTest { | |||
| TestTextField("hello") | |||
| } | |||
|
|
|||
| with(rule.onNodeWithTag("tag")){ | |||
| with(rule.onNodeWithTag("tag")) { | |||
There was a problem hiding this comment.
It looks like only whitespace changed in this file
There was a problem hiding this comment.
Yes, I fixed it here and in a bunch of other test files.
m-sasha
force-pushed
the
m-sasha/dialog-and-window-scenes-in-test-roots
branch
from
3d4bd82
to
5fd71e6
Compare
m-sasha
force-pushed
the
m-sasha/add-semantic-properties-to-dialogwindow-popup-and-dialog
branch
2 times, most recently
from
ed8278e
to
09cd413
Compare
MatkovIvan
approved these changes
Jul 21, 2023
igordmn
approved these changes
Jul 21, 2023
m-sasha
force-pushed
the
m-sasha/dialog-and-window-scenes-in-test-roots
branch
from
5fd71e6
to
8b8cc84
Compare
m-sasha
force-pushed
the
m-sasha/add-semantic-properties-to-dialogwindow-popup-and-dialog
branch
from
09cd413
to
311a2e5
Compare
MatkovIvan
reviewed
Jul 24, 2023
m-sasha
force-pushed
the
m-sasha/dialog-and-window-scenes-in-test-roots
branch
3 times, most recently
from
90c1950
to
4862e61
Compare
Base automatically changed from
m-sasha/dialog-and-window-scenes-in-test-roots
to
jb-main
July 24, 2023 12:57
m-sasha
force-pushed
the
m-sasha/add-semantic-properties-to-dialogwindow-popup-and-dialog
branch
from
311a2e5
to
4769460
Compare
m-sasha
force-pushed
the
m-sasha/add-semantic-properties-to-dialogwindow-popup-and-dialog
branch
from
4769460
to
e732e9a
Compare
m-sasha
deleted the
m-sasha/add-semantic-properties-to-dialogwindow-popup-and-dialog
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
dialog()semantic property toDialogWindow.dialog()semantic property toDialogpopup()semantic property toPopup.Testing
Test: Added (and enabled) unit tests for this.