Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cfw: make CanvasBasedWindow apply default styles, set title #722

Merged
merged 1 commit into from Aug 2, 2023

Conversation

OliverO2
Copy link

Proposed Changes

  • Integrate style settings to use the entire inner window into CanvasBasedWindow for a better out-of-the-box experience, omitting the need for external style declarations.
  • Support setting the HTML title element (parameter was unused before).

Testing

Test: Adapted the mpp/demo app, tested appearance, resizing, title parameter set/unset.

Remarks

Style settings are limited to the necessary and sufficient set of styles required by browsers as verified via

@eymar eymar self-requested a review August 1, 2023 06:13
Copy link
Collaborator

@eymar eymar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eymar eymar merged commit 1c909ba into JetBrains:jb-main Aug 2, 2023
@OliverO2
Copy link
Author

OliverO2 commented Aug 2, 2023

Excellent cooperation. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants