Limit max Dialog and Popup size by safe area on iOS
#732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+64
to
+68
| actual class PopupProperties @ExperimentalComposeUiApi constructor( | ||
| actual val focusable: Boolean, | ||
| actual val dismissOnBackPress: Boolean, | ||
| actual val dismissOnClickOutside: Boolean | ||
| actual val dismissOnClickOutside: Boolean, | ||
| val usePlatformDefaultWidth: Boolean = false, |
There was a problem hiding this comment.
Addition of a new argument (even with default value) will break binary backward compatibility on stable Desktop.
There was a problem hiding this comment.
Or this class doesn't exists in Compose Multiplatform 1.4.3 ?
There was a problem hiding this comment.
As I see this class doesn't exists in 1.4.3
So, we need to cherry pick this PR also to preparing branch of Compose Multiplatform 1.5.0 Release ?
dima-avdeev-jb
approved these changes
Aug 8, 2023
igordmn
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
DialogandPopupsize by safe area on iOSPopupandDialogtoRootMeasurePolicyusePlatformDefaultWidthparameter toPopupPropertiesTesting
Test: run
mppdemo, open max sizeDialog