Add crossfade animation during orientation change when used within UIKit hierarchy #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge transition to avoid timing issues between UIKit logic and Compose render.
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/window/ComposeWindow.uikit.kt
Outdated
Show resolved
Hide resolved
|
Found janks in our Demo project on simulator: Screen.Recording.2023-08-30.at.19.54.20.mp4 |
…ComposeWindow.uikit.kt Co-authored-by: dima.avdeev <dima.avdeev@jetbrains.com>
Fixed in 0a22390 |
# Conflicts: # compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/window/ComposeWindow.uikit.kt
dima-avdeev-jb
approved these changes
Aug 31, 2023
MatkovIvan
reviewed
Sep 1, 2023
| updateLayout(it) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private fun UIViewController.checkIfInsideSwiftUI(): Boolean { | ||
| var parent = parentViewController |
There was a problem hiding this comment.
This part is not formatter properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add crossfade animation during orientation change to avoid stretching (Compose doesn't support per-view frame interpolation like native UIKit does)
Testing
Test: instantiate ComposeWindow outside of SwiftUI UIViewControllerRepresentable context, rotate the device.
Videos
Before
RPReplay_Final1693396041.MP4
After
RPReplay_Final1693395717.MP4
RPReplay_Final1693395836.MP4