Expect material3.ExposedDropdownMenuBox in common
#787
Conversation
MatkovIvan
force-pushed
the
ivan.matkov/windowinfo-size
branch
from
b2bffb2
to
f2b7055
Compare
| transformOriginState.value = calculateTransformOrigin(anchorBounds, menuBounds) | ||
| } | ||
| @Composable | ||
| actual fun ExposedDropdownMenuBoxScope.ExposedDropdownMenu( |
There was a problem hiding this comment.
This will break binary backwards-compatibility on Android; not sure how important it is, though. @igordmn can say better.
There was a problem hiding this comment.
interface and extensions functions also differ on source level, so it is undesirable to have such difference.
It seems, we can just copy ExposedDropdownMenuBoxScope to commonMain, and make only ExposedDropdownMenuPopup expect/actual, instead of the full interface?
There was a problem hiding this comment.
Extracted expect/actual into internal function
| } | ||
|
|
||
| @OptIn(ExperimentalComposeUiApi::class) | ||
| private fun updateHeight( |
There was a problem hiding this comment.
This can be simplified to just return the new height, but could make it harder to merge changes from upstream. Not sure what takes precedence.
There was a problem hiding this comment.
I would simplify it. Most probably we won't be updating updateHeight from upstream, as it depends on other pieces.
MatkovIvan
force-pushed
the
ivan.matkov/common-exposed-dropdown3
branch
from
6404eeb
to
23c9367
Compare
...material3/material3/src/androidMain/kotlin/androidx/compose/material3/ExposedDropdownMenu.kt
Outdated
Show resolved
Hide resolved
...rial3/material3/src/skikoMain/kotlin/androidx/compose/material3/ExposedDropdownMenu.skiko.kt
Outdated
Show resolved
Hide resolved
...rial3/material3/src/skikoMain/kotlin/androidx/compose/material3/ExposedDropdownMenu.skiko.kt
Outdated
Show resolved
Hide resolved
MatkovIvan
changed the title
material3.ExposedDropdownMenuBox in common
* Expect ExposedDropdownMenuBox in common * Add ExposedDropdownMenu3Sample * Update to windowInfo.containerSize * Move ExposedDropdownMenuDefaults to common * Simplify updateHeight * Fix import
…enuBox` in common (#787) * Expect ExposedDropdownMenuBox in common * Add ExposedDropdownMenu3Sample * Update to windowInfo.containerSize * Move ExposedDropdownMenuDefaults to common * Simplify updateHeight * Fix import
* Expect ExposedDropdownMenuBox in common * Add ExposedDropdownMenu3Sample * Update to windowInfo.containerSize * Move ExposedDropdownMenuDefaults to common * Simplify updateHeight * Fix import
Proposed Changes
ExposedDropdownMenuBoxin common and implement for skikoAPI Changes
Testing
Test: Try to use
ExposedDropdownMenuBoxfrom common or look at mpp demoIssues Fixed
Fixes JetBrains/compose-multiplatform#2037