iOS modify invalidation logic #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
reviewed
Sep 11, 2023
| * limitations under the License. | ||
| */ | ||
|
|
||
| package bugs |
There was a problem hiding this comment.
Should we move it to more specific package?
There was a problem hiding this comment.
If you want to, it's our sandbox
There was a problem hiding this comment.
This package already exists, so if want to rename it we should do it in a separate PR.
I don't have preference to either naming style (bugs or androidx.compose.mpp.demo.bugs). Both are fine to me.
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/window/MetalRedrawer.kt
Show resolved
Hide resolved
igordmn
reviewed
Sep 12, 2023
| * limitations under the License. | ||
| */ | ||
|
|
||
| package bugs |
There was a problem hiding this comment.
This package already exists, so if want to rename it we should do it in a separate PR.
I don't have preference to either naming style (bugs or androidx.compose.mpp.demo.bugs). Both are fine to me.
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/window/MetalRedrawer.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/window/MetalRedrawer.kt
igordmn
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
If subsequent
setPaused: true:setPaused: falsehappen on different main RunLoop jobs, actual restart of CADisplayLink takes 16 ms (two intervals).Proposed Changes
Since invalidation, which triggers unpause, happens asynchronously, we can avoid that behavior by forcing
needRedrawcall to unpause CADisplayLink for at least two frames (instead of one).Remove
getMainDispatcher.Dispatchers.Mainworks correctly now and doesn't need a workaround.Testing
Test: check that animations are 120hz on 120hz devices, even when there are no touches tracked.
Issues Fixed
Fixes: scheduling causing JetBrains/compose-multiplatform#3605. It's not the only reason for lower FPS.