Double tap and triple tap gesture handling in textfields on iOS #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
dima-avdeev-jb
approved these changes
Sep 20, 2023
...ndation/src/uikitMain/kotlin/androidx/compose/foundation/gestures/UIKitTapGestureDetector.kt
Outdated
Show resolved
Hide resolved
...ndation/src/uikitMain/kotlin/androidx/compose/foundation/gestures/UIKitTapGestureDetector.kt
Outdated
Show resolved
Hide resolved
igordmn
reviewed
Sep 21, 2023
...tion/src/uikitMain/kotlin/androidx/compose/foundation/text/TextFieldPointerModifier.uikit.kt
Outdated
Show resolved
Hide resolved
.../src/androidMain/kotlin/androidx/compose/foundation/text/TextFieldPointerModifier.android.kt
Show resolved
Hide resolved
...ndation/src/uikitMain/kotlin/androidx/compose/foundation/gestures/UIKitTapGestureDetector.kt
Outdated
Show resolved
Hide resolved
...tion/src/uikitMain/kotlin/androidx/compose/foundation/text/TextFieldPointerModifier.uikit.kt
Show resolved
Hide resolved
...tion/src/uikitMain/kotlin/androidx/compose/foundation/text/TextFieldPointerModifier.uikit.kt
Outdated
Show resolved
Hide resolved
...ndation/src/uikitMain/kotlin/androidx/compose/foundation/gestures/UIKitTapGestureDetector.kt
Outdated
Show resolved
Hide resolved
...ndation/src/uikitMain/kotlin/androidx/compose/foundation/gestures/UIKitTapGestureDetector.kt
Outdated
Show resolved
Hide resolved
...ndation/src/uikitMain/kotlin/androidx/compose/foundation/gestures/UIKitTapGestureDetector.kt
Outdated
Show resolved
Hide resolved
.../src/androidMain/kotlin/androidx/compose/foundation/text/TextFieldPointerModifier.android.kt
Show resolved
Hide resolved
...tion/src/uikitMain/kotlin/androidx/compose/foundation/text/TextFieldPointerModifier.uikit.kt
Outdated
Show resolved
Hide resolved
igordmn
reviewed
Sep 21, 2023
.../src/androidMain/kotlin/androidx/compose/foundation/text/TextFieldPointerModifier.android.kt
Show resolved
Hide resolved
… in uikit sourceset
…ompose/foundation/text/TextFieldPointerModifier.common.kt Co-authored-by: Igor Demin <igordmn@users.noreply.github.com>
…mpose/foundation/text/TextFieldPointerModifier.uikit.kt Co-authored-by: Igor Demin <igordmn@users.noreply.github.com>
…mpose/foundation/text/TextFieldPointerModifier.uikit.kt Co-authored-by: Igor Demin <igordmn@users.noreply.github.com>
…mpose/foundation/text/TextFieldPointerModifier.uikit.kt Co-authored-by: Igor Demin <igordmn@users.noreply.github.com>
… added handling of tap, double tap and triple tap on textfield
mazunin-v-jb
force-pushed
the
v.mazunin/new-uikit-tap-detector-for-textfield
branch
from
6fe5f86
to
a8b1134
Compare
move tap detection logic to skiko remove redunant code remove duplicate
mazunin-v-jb
deleted the
v.mazunin/new-uikit-tap-detector-for-textfield
branch
igordmn
added a commit
that referenced
this pull request
Nov 15, 2023
…textfields on iOS (#831) ## Proposed Changes Added UIKitTapGesturesDetector.kt - repeating tap gestures detector. Moved and separated the logic for handling taps in the textfields. Added handling of double and triple taps in the textfields on iOS. This PR also includes review fixes from [my previous, closed one](#798) ## Testing Test: Open any screen with textfield with mutable text, then try to double or triple tap on text (or if its empty, write something in it). Try to test with focused textfield and unfocused. Double tap selects the word, triple tap selects the paragraph. ## Issues Fixed JetBrains/compose-multiplatform#2682 https://youtrack.jetbrains.com/issue/COMPOSE-333/iOS-TextField-Incorrect-behavior-of-text-selection-by-double-tap (YT double version of the previous issue) https://youtrack.jetbrains.com/issue/COMPOSE-409/iOS-TextField-support-triple-tap-handle ## Google CLA You need to sign the Google Contributor’s License Agreement at https://cla.developers.google.com/. This is needed since we synchronise most of the code with Google’s AOSP repository. Signing this agreement allows us to synchronise code from your Pull Requests as well. --------- Co-authored-by: dima.avdeev <dima.avdeev@jetbrains.com> Co-authored-by: Igor Demin <igordmn@users.noreply.github.com>
igordmn
added a commit
that referenced
this pull request
Nov 16, 2023
…tap gesture handling in textfields on iOS (#831) ## Proposed Changes Added UIKitTapGesturesDetector.kt - repeating tap gestures detector. Moved and separated the logic for handling taps in the textfields. Added handling of double and triple taps in the textfields on iOS. This PR also includes review fixes from [my previous, closed one](#798) ## Testing Test: Open any screen with textfield with mutable text, then try to double or triple tap on text (or if its empty, write something in it). Try to test with focused textfield and unfocused. Double tap selects the word, triple tap selects the paragraph. ## Issues Fixed JetBrains/compose-multiplatform#2682 https://youtrack.jetbrains.com/issue/COMPOSE-333/iOS-TextField-Incorrect-behavior-of-text-selection-by-double-tap (YT double version of the previous issue) https://youtrack.jetbrains.com/issue/COMPOSE-409/iOS-TextField-support-triple-tap-handle ## Google CLA You need to sign the Google Contributor’s License Agreement at https://cla.developers.google.com/. This is needed since we synchronise most of the code with Google’s AOSP repository. Signing this agreement allows us to synchronise code from your Pull Requests as well. --------- Co-authored-by: dima.avdeev <dima.avdeev@jetbrains.com> Co-authored-by: Igor Demin <igordmn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Added UIKitTapGesturesDetector.kt - repeating tap gestures detector.
Moved and separated the logic for handling taps in the textfields.
Added handling of double and triple taps in the textfields on iOS.
This PR also includes review fixes from my previous, closed one
Testing
Test: Open any screen with textfield with mutable text, then try to double or triple tap on text (or if its empty, write something in it). Try to test with focused textfield and unfocused.
Double tap selects the word, triple tap selects the paragraph.
Issues Fixed
JetBrains/compose-multiplatform#2682
https://youtrack.jetbrains.com/issue/COMPOSE-333/iOS-TextField-Incorrect-behavior-of-text-selection-by-double-tap (YT double version of the previous issue)
https://youtrack.jetbrains.com/issue/COMPOSE-409/iOS-TextField-support-triple-tap-handle
Google CLA
You need to sign the Google Contributor’s License Agreement at https://cla.developers.google.com/.
This is needed since we synchronise most of the code with Google’s AOSP repository. Signing this agreement allows us to synchronise code from your Pull Requests as well.