Implement temporary workaround for interop view intercepting touches for popups. #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igordmn
reviewed
Sep 21, 2023
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/window/ComposeWindow.uikit.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/window/ComposeWindow.uikit.kt
Outdated
Show resolved
Hide resolved
MatkovIvan
reviewed
Sep 22, 2023
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/window/ComposeWindow.uikit.kt
Outdated
Show resolved
Hide resolved
| (y * density.density).toFloat() | ||
| ) | ||
|
|
||
| // TODO: temporary solution copying control flow from [ComposeScene.processPress] |
There was a problem hiding this comment.
FYI agreed that it's temporary - it shouldn't replicate this logic (that will be refactored soon). More correct way to send touches to scene as black box and handle only that ones that were received in interop view (compose layout inside owner)
There was a problem hiding this comment.
Yeah, agree. This is a rather trivial solution and solves a reported issue, so I don't see harm in it.
…ComposeWindow.uikit.kt Co-authored-by: Ivan Matkov <ivan.matkov@jetbrains.com>
igordmn
reviewed
Sep 22, 2023
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/ComposeScene.skiko.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/ComposeScene.skiko.kt
Outdated
Show resolved
Hide resolved
…Scene.skiko.kt Co-authored-by: Igor Demin <igordmn@users.noreply.github.com>
igordmn
approved these changes
Sep 22, 2023
|
merge jb-main to CI to pass |
MatkovIvan
approved these changes
Sep 25, 2023
What is this performance monitoring tool in the screenshot?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Traverse owners top down and see, if the touch should be dispatched into compose instead of interop view.
Testing
Test: check ComposeDemo IosBugs/UIKitViewAndDropDown example to work correctly.
Issues Fixed
Fixes: interop view intercepting touches on compose popup on top of it.
RPReplay_Final1695302596.MP4