Commonize insets Modifier's #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igordmn
approved these changes
Sep 22, 2023
dima-avdeev-jb
approved these changes
Sep 23, 2023
igordmn
pushed a commit
that referenced
this pull request
Nov 15, 2023
## Proposed Changes ```diff +fun Modifier.safeDrawingPadding(): Modifier +fun Modifier.safeGesturesPadding(): Modifier +fun Modifier.safeContentPadding(): Modifier +fun Modifier.systemBarsPadding(): Modifier +fun Modifier.displayCutoutPadding(): Modifier +fun Modifier.statusBarsPadding(): Modifier +fun Modifier.imePadding(): Modifier +fun Modifier.navigationBarsPadding(): Modifier +fun Modifier.captionBarPadding(): Modifier +fun Modifier.waterfallPadding(): Modifier +fun Modifier.systemGesturesPadding(): Modifier +fun Modifier.mandatorySystemGesturesPadding(): Modifier ``` ## Testing Test: TBD ## Issues Fixed Fixes JetBrains/compose-multiplatform#3563
igordmn
pushed a commit
that referenced
this pull request
Nov 16, 2023
…r's (#837) ## Proposed Changes ```diff +fun Modifier.safeDrawingPadding(): Modifier +fun Modifier.safeGesturesPadding(): Modifier +fun Modifier.safeContentPadding(): Modifier +fun Modifier.systemBarsPadding(): Modifier +fun Modifier.displayCutoutPadding(): Modifier +fun Modifier.statusBarsPadding(): Modifier +fun Modifier.imePadding(): Modifier +fun Modifier.navigationBarsPadding(): Modifier +fun Modifier.captionBarPadding(): Modifier +fun Modifier.waterfallPadding(): Modifier +fun Modifier.systemGesturesPadding(): Modifier +fun Modifier.mandatorySystemGesturesPadding(): Modifier ``` ## Testing Test: TBD ## Issues Fixed Fixes JetBrains/compose-multiplatform#3563
copybara-service bot
pushed a commit
to androidx/androidx
that referenced
this pull request
May 15, 2024
It's upstreaming of JetBrains#837. This API is already available from common since Compose Multiplatform 1.5.10 Test: N/A Relnote: Make WindowInsetsPadding modifiers available from common source set Change-Id: I070b2fbfc6dcae41be4bc9bf313d5847065d4053
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Testing
Test: TBD
Issues Fixed
Fixes JetBrains/compose-multiplatform#3563