Fix Accessibility. Crash on text hover on Windows #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes JetBrains/compose-multiplatform#3742 The fix is cherry-picked from androidx@7a7f57c to jb-main (it contains other fix as well) Because we always return `false`, we [have textLayoutResult = null](https://github.com/JetBrains/compose-multiplatform-core/blob/7f72ab8719252acaafc753a9aa28d2940ea995df/compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/ComposeAccessible.kt#L116) It isn't reproducible on macOs because it doesn't call `ComposeAccessibleText.getCharacterBounds`
m-sasha
approved these changes
Oct 3, 2023
Walingar
pushed a commit
that referenced
this pull request
Oct 5, 2023
Fix Accessibility. Crash on text hover on Windows Fixes JetBrains/compose-multiplatform#3742 The fix is cherry-picked from androidx@7a7f57c to jb-main (it contains other fix as well) Because we always return `false`, we [have textLayoutResult = null](https://github.com/JetBrains/compose-multiplatform-core/blob/7f72ab8719252acaafc753a9aa28d2940ea995df/compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/ComposeAccessible.kt#L116) It isn't reproducible on macOs because it doesn't call `ComposeAccessibleText.getCharacterBounds` # Test 1. Modified AccessibilityTest (it fails before the fix on Windows/macOs) 2. VoiceOver pronounces the hovered Text on macOs, Windows
mazunin-v-jb
pushed a commit
that referenced
this pull request
Dec 7, 2023
Fix Accessibility. Crash on text hover on Windows Fixes JetBrains/compose-multiplatform#3742 The fix is cherry-picked from androidx@7a7f57c to jb-main (it contains other fix as well) Because we always return `false`, we [have textLayoutResult = null](https://github.com/JetBrains/compose-multiplatform-core/blob/7f72ab8719252acaafc753a9aa28d2940ea995df/compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/ComposeAccessible.kt#L116) It isn't reproducible on macOs because it doesn't call `ComposeAccessibleText.getCharacterBounds` # Test 1. Modified AccessibilityTest (it fails before the fix on Windows/macOs) 2. VoiceOver pronounces the hovered Text on macOs, Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Accessibility. Crash on text hover on Windows
Fixes JetBrains/compose-multiplatform#3742
The fix is cherry-picked from androidx@7a7f57c to jb-main
(it contains other fix as well)
Because we always return
false, we have textLayoutResult = nullIt isn't reproducible on macOs because it doesn't call
ComposeAccessibleText.getCharacterBoundsTest