Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report semantic ProgressBarRangeInfo changes. #862

Merged
merged 1 commit into from Oct 10, 2023

Conversation

m-sasha
Copy link

@m-sasha m-sasha commented Oct 7, 2023

Currently, we don't report progress bar value changes to the accessibility system.

Proposed Changes

Fire a property change event when the ProgressBarRangeInfo value changes. This is what Swing's JProgressBar does.

Testing

Test: Ran this with VoiceOver on:

fun main() = singleWindowApplication {
    Column {
        var progress by remember { mutableStateOf(0.0f) }

        LinearProgressIndicator(
            progress,
            modifier = Modifier.focusable().height(16.dp)
        )

        LaunchedEffect(progress) {
            if (progress < 1f) {
                delay(2000)
                progress += 0.1f
            }
        }
    }
}

@m-sasha m-sasha requested a review from Walingar October 7, 2023 08:04
@m-sasha m-sasha merged commit 5cab950 into jb-main Oct 10, 2023
3 checks passed
@m-sasha m-sasha deleted the m-sasha/live-progressbar-a11y branch October 10, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants