iOS. Fixed bug with selection handle #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
reviewed
Oct 11, 2023
| @@ -25,5 +25,6 @@ val IosBugs = Screen.Selection( | |||
| KeyboardPasswordType, | |||
| UIKitRenderSync, | |||
| DispatchersMainDelayCheck, | |||
| StartRecompositionCheck | |||
| StartRecompositionCheck, | |||
| SelectionHandlePadding, | |||
There was a problem hiding this comment.
Please move it to common, there is no specific uikit API usage here.
There was a problem hiding this comment.
Code sample not iOS only. So, moved to commonMain sourceSet in TextFields section
MatkovIvan
reviewed
Oct 11, 2023
| @@ -52,6 +54,7 @@ private val RADIUS = 6.dp | |||
| */ | |||
| private val THICKNESS = 2.dp | |||
|
|
|||
| @OptIn(ExperimentalComposeUiApi::class) | |||
There was a problem hiding this comment.
BTW It's cross-module experimental, but that's not first usage of it. So I guess it's OK here.
There was a problem hiding this comment.
Thanks for notice about it!
| @@ -25,5 +25,6 @@ val IosBugs = Screen.Selection( | |||
| KeyboardPasswordType, | |||
| UIKitRenderSync, | |||
| DispatchersMainDelayCheck, | |||
| StartRecompositionCheck | |||
| StartRecompositionCheck, | |||
| SelectionHandlePadding, | |||
There was a problem hiding this comment.
Please move it to common, there is no specific uikit API usage here.
dima-avdeev-jb
changed the title
MatkovIvan
approved these changes
Oct 12, 2023
mazunin-v-jb
pushed a commit
that referenced
this pull request
Dec 7, 2023
Previously SelectionHandle looks like this on BasicTextField: It was because of Popup padding Not, it was fixed:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously SelectionHandle looks like this on BasicTextField:
It was because of Popup padding
Not, it was fixed: