Make MouseEvent.nativeEvent and KeyEvent.nativeKeyEvent as Any? #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also introduce extensions, which should be used by the users, if they need interop with AWT: val PointerEvent.awtEvent: java.awt.event.MouseEvent val KeyEvent.awtEvent: java.awt.event.KeyEvent We don't yet support non-awt events, as we cast to it internally, but we can do it in the future, when we get rid of this casting. Make JetBrains/compose-multiplatform#1348 irrelevant. We can introduce new types in the future. I don't want to mark it experimental because: - these types can be used in libraries, it is better if make them backward compatible - the current PR proposal covers all known cases for our future API - this API looks pretty simple to write fallback, if we deprecate them someday
olonho
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also introduce extensions, which should be used by the users, if they need interop with AWT:
val PointerEvent.awtEvent: java.awt.event.MouseEvent
val KeyEvent.awtEvent: java.awt.event.KeyEvent
We don't yet support non-awt events, as we cast to it internally, but we can do it in the future, when we get rid of this casting.
Make JetBrains/compose-multiplatform#1348 irrelevant.
We can introduce new types in the future.
I don't want to mark it experimental because: