Update Skiko to 0.7.84, fix failed tests after updating coroutines #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Walingar
approved these changes
Oct 12, 2023
igordmn
changed the title
igordmn
changed the title
igordmn
changed the title
igordmn
changed the title
Walingar
approved these changes
Oct 13, 2023
mazunin-v-jb
pushed a commit
that referenced
this pull request
Dec 7, 2023
) - Update Skiko to 0.7.84 ([Diff](JetBrains/skiko@v0.7.80...v0.7.84)) - Because it updates Coroutines to 1.7.3, now we have failing tests, they are migrated to the new coroutine version Having 1.7.3 in dependencies is okay, as it depends on [Kotlin 1.8.20](https://github.com/Kotlin/kotlinx.coroutines/blob/master/CHANGES_UP_TO_1.7.md#version-170) (Compose 1.5 depends on 1.8.21). Besides that, [Jetpack Compose 1.6 already depends on 1.7.1](https://github.com/androidx/androidx/blob/e502da69dcec7dc8662241de58f34399e7b0abe8/gradle/libs.versions.toml#L47)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having 1.7.3 in dependencies is okay, as it depends on Kotlin 1.8.20 (Compose 1.5 depends on 1.8.21). Besides that, Jetpack Compose 1.6 already depends on 1.7.1