Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronize IME insets with iOS keyboard #875

Merged
merged 2 commits into from Oct 23, 2023
Merged

Synchronize IME insets with iOS keyboard #875

merged 2 commits into from Oct 23, 2023

Conversation

terrakok
Copy link

@terrakok terrakok commented Oct 13, 2023 •
edited

Proper support of the keyboard animation

@google-cla
Copy link

google-cla bot commented Oct 13, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@dima-avdeev-jb
Copy link

@terrakok Can you please merge latest changes from jb-main branch

@terrakok terrakok force-pushed the k.tskh/ios-keyboard-animation branch from 4739ce3 to 6747f2a Compare October 16, 2023 11:41
@terrakok terrakok force-pushed the k.tskh/ios-keyboard-animation branch from 6747f2a to 6bc23ee Compare October 16, 2023 12:39
@elijah-semyonov
Copy link

LGTM, the only question is UIView.animateWithDuration default curve is correct?
See https://developer.apple.com/documentation/uikit/uiresponder/1621613-keyboardanimationcurveuserinfoke

@terrakok @dima-avdeev-jb
Use explicit constructor instead of new() method
5e3724b 
Co-authored-by: dima.avdeev <dima.avdeev@jetbrains.com>
@terrakok
Copy link
Author

Regarding the default curve, as I understood, default is linear and it is good for us. We can extract it from the keyboard options but it is not required, I guess

@terrakok terrakok merged commit 9eef63d into jb-main Oct 23, 2023
3 checks passed
@terrakok terrakok deleted the k.tskh/ios-keyboard-animation branch October 23, 2023 21:28
mazunin-v-jb pushed a commit that referenced this pull request Dec 7, 2023
@terrakok @dima-avdeev-jb @mazunin-v-jb
Synchronize IME insets with iOS keyboard (#875)
3f8d894 
Proper support of the keyboard animation

---------

Co-authored-by: dima.avdeev <dima.avdeev@jetbrains.com>
@alexzhirkevich alexzhirkevich mentioned this pull request Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatkovIvan MatkovIvan MatkovIvan left review comments

@elijah-semyonov elijah-semyonov elijah-semyonov left review comments

@dima-avdeev-jb dima-avdeev-jb dima-avdeev-jb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@terrakok @dima-avdeev-jb @elijah-semyonov @MatkovIvan