Use larger icon size for Window's IconImage #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids blurry icons on window switchers (Alt+Tab) on Windows and Linux.
igordmn
approved these changes
Nov 10, 2023
mazunin-v-jb
pushed a commit
that referenced
this pull request
Dec 7, 2023
This avoids blurry icons on window switchers (Alt+Tab) on Windows and Linux. ## Proposed Changes - change icon image size for windows to a larger base image 192px instead of 32px, otherwise we end up with blurry icons (see JetBrains/compose-multiplatform#1838) ## Testing Test: I have not tested this change directly, but am using this size on other apps to set the size and this seems to work well on the systems I tried on. ## Issues Fixed Fixes: JetBrains/compose-multiplatform#1838 ## Google CLA You need to sign the Google Contributor’s License Agreement at https://cla.developers.google.com/. This is needed since we synchronise most of the code with Google’s AOSP repository. Signing this agreement allows us to synchronise code from your Pull Requests as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids blurry icons on window switchers (Alt+Tab) on Windows and Linux.
Proposed Changes
Testing
Test: I have not tested this change directly, but am using this size on other apps to set the size and this seems to work well on the systems I tried on.
Issues Fixed
Fixes: JetBrains/compose-multiplatform#1838
Google CLA
You need to sign the Google Contributor’s License Agreement at https://cla.developers.google.com/.
This is needed since we synchronise most of the code with Google’s AOSP repository. Signing this agreement allows us to synchronise code from your Pull Requests as well.