ComposeScene/Owner refactor (Part 1)
#891
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
force-pushed
the
ivan.matkov/owner-refactor-1
branch
from
c4e32a8
to
76918fc
Compare
MatkovIvan
changed the base branch from
jb-main
to
ivan.matkov/test-owner-registry
MatkovIvan
force-pushed
the
ivan.matkov/owner-refactor-1
branch
from
76918fc
to
54fcdbc
Compare
MatkovIvan
force-pushed
the
ivan.matkov/owner-refactor-1
branch
2 times, most recently
from
826e13b
to
fa9f68a
Compare
MatkovIvan
added a commit
that referenced
this pull request
Nov 10, 2023
## Proposed Changes It's a part of #891 - Add callbacks to `SkiaRootForTest` to collect references in `ComposeRootRegistry` (original Google's approach like in the Android source set) - Remove "child" scenes introduced in #697. Currently it's handled in `ComposeRootRegistry` (tests-only) - Deprecate `ComposeScene.roots` that was never intended to be public - Address TODO in `isInScreenBounds()`: `contentSize` instead of `containerSize` where used ## Testing Test: CI should pass, everything should work as before
MatkovIvan
force-pushed
the
ivan.matkov/owner-refactor-1
branch
from
ac99515
to
626094a
Compare
Merged
MatkovIvan
added a commit
that referenced
this pull request
Nov 24, 2023
## Proposed Changes It's the evolution of #891 Compose scene: - Deprecate the existing API and introduce an internal interface instead - Remove key listeners from `setContent` - `constraints` -> `size` - Add `lastKnownPointerPosition` to public interface - `CombinedComposeScene` as a compatible version of scene - Remove recently added `semanticsOwner` - `ComposeScene.Pointer` -> `ComposeScenePointer` Other changes: - Rename `SkiaBasedOwner` to `RootNodeOwner`. Also, it uses aggregation instead of implementing a few interfaces. - `SkikoComposeUiTest` overrides `PlatformContext.RootForTestListener` now. It solves TODOs about `WindowInfo` in tests. - `SkiaRootForTest` is renamed to `PlatformRootForTest` - `onRootCreatedCallback`/`onRootDisposedCallback` is now part of `PlatformContext` - `PlatformRootForTest` exposes real `visibleBounds` instead of just window size information. - `PlatformRootForTest` exposes send pointer input methods instead of `scene` reference. - `InternalComposeUiApi` is opted in inside the same module. - `Platform` -> `PlatfromContext` - `dialogScrimBlendMode` -> `isWindowTransparent` - `AccessibilityController`: Remove interface from `skikoMain` source set - `AccessibilityController`: `syncLoop` triggered right from desktop-only part - Replaced `Platform.accessibilityController(SemanticsOwner)` to `semanticsOwnerListener` - Fixes an invalid test case: out of screen Popup cannot receive input now - Removed unnecessary expect/actual `createSkiaLayer` - Moves "Deprecated" `DefaultViewConfiguration` to test where there is a single usage of it. ## API Changes See `compose/ui/ui/api/desktop/ui.api` file ## Testing Test: run existing tests.
mazunin-v-jb
pushed a commit
that referenced
this pull request
Dec 7, 2023
## Proposed Changes It's a part of #891 - Add callbacks to `SkiaRootForTest` to collect references in `ComposeRootRegistry` (original Google's approach like in the Android source set) - Remove "child" scenes introduced in #697. Currently it's handled in `ComposeRootRegistry` (tests-only) - Deprecate `ComposeScene.roots` that was never intended to be public - Address TODO in `isInScreenBounds()`: `contentSize` instead of `containerSize` where used ## Testing Test: CI should pass, everything should work as before
mazunin-v-jb
pushed a commit
that referenced
this pull request
Dec 7, 2023
## Proposed Changes It's the evolution of #891 Compose scene: - Deprecate the existing API and introduce an internal interface instead - Remove key listeners from `setContent` - `constraints` -> `size` - Add `lastKnownPointerPosition` to public interface - `CombinedComposeScene` as a compatible version of scene - Remove recently added `semanticsOwner` - `ComposeScene.Pointer` -> `ComposeScenePointer` Other changes: - Rename `SkiaBasedOwner` to `RootNodeOwner`. Also, it uses aggregation instead of implementing a few interfaces. - `SkikoComposeUiTest` overrides `PlatformContext.RootForTestListener` now. It solves TODOs about `WindowInfo` in tests. - `SkiaRootForTest` is renamed to `PlatformRootForTest` - `onRootCreatedCallback`/`onRootDisposedCallback` is now part of `PlatformContext` - `PlatformRootForTest` exposes real `visibleBounds` instead of just window size information. - `PlatformRootForTest` exposes send pointer input methods instead of `scene` reference. - `InternalComposeUiApi` is opted in inside the same module. - `Platform` -> `PlatfromContext` - `dialogScrimBlendMode` -> `isWindowTransparent` - `AccessibilityController`: Remove interface from `skikoMain` source set - `AccessibilityController`: `syncLoop` triggered right from desktop-only part - Replaced `Platform.accessibilityController(SemanticsOwner)` to `semanticsOwnerListener` - Fixes an invalid test case: out of screen Popup cannot receive input now - Removed unnecessary expect/actual `createSkiaLayer` - Moves "Deprecated" `DefaultViewConfiguration` to test where there is a single usage of it. ## API Changes See `compose/ui/ui/api/desktop/ui.api` file ## Testing Test: run existing tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
SkiaBasedOwnertoRootNodeOwnerownerslist fromComposeSceneclassCombinedRootNodeOwnerto allow adding multiple root nodes to the same canvas/ComposeSceneComposeSceneAccessiblenow uses the newaccessibilityControllersowner propertyTesting
Test: CI should pass, everything should work as before