Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update skiko to 0.7.87 #899

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Update skiko to 0.7.87 #899

merged 4 commits into from
Nov 10, 2023

Conversation

MatkovIvan
Copy link
Member

Proposed Changes

  • Update skiko to 0.7.87

Issues Fixed

Fixes JetBrains/compose-multiplatform#1888
image

@igordmn
Copy link
Collaborator

igordmn commented Nov 9, 2023 •
edited

  • as far as I remember we had failed screnshots tests because of the changed antialiasing in the new Skia (at least on Windows, didn't check on macOs)
  • we renamed the skiko artifact (I will make a PR later)

@igordmn
Copy link
Collaborator

igordmn commented Nov 10, 2023 •
edited

we renamed the skiko artifact (I will make a PR later)

false alert, we made a mistake in the change, and effectively didn't change anything yet (but we will later)

igordmn
igordmn approved these changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@igordmn igordmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed the screenshots. Now it is safe to merge

@Walingar
Copy link
Collaborator

Let's merge and build Compose dev version before merging 1.6.0 Jetpack Compose

@MatkovIvan MatkovIvan merged commit 3d00945 into jb-main Nov 10, 2023
3 checks passed
@MatkovIvan MatkovIvan deleted the ivan.matkov/skiko-0.7.87 branch November 10, 2023 13:22
eymar pushed a commit that referenced this pull request Dec 5, 2023
@MatkovIvan @eymar
Update skiko to 0.7.87 (#899)
5251ad3 
## Proposed Changes

- Update skiko to `0.7.87`

## Issues Fixed

Fixes JetBrains/compose-multiplatform#1888
<img width="310" alt="image"
src="https://github.com/JetBrains/compose-multiplatform-core/assets/1836384/dd28cc81-1d5d-4119-b9fa-0e1e4e28f794">

---------

Co-authored-by: Igor Demin <igor.demin@jetbrains.com>

(cherry picked from commit 3d00945)
mazunin-v-jb pushed a commit that referenced this pull request Dec 7, 2023
@MatkovIvan @igordmn @mazunin-v-jb
Update skiko to 0.7.87 (#899)
5c90d69 
## Proposed Changes

- Update skiko to `0.7.87`

## Issues Fixed

Fixes JetBrains/compose-multiplatform#1888
<img width="310" alt="image"
src="https://github.com/JetBrains/compose-multiplatform-core/assets/1836384/dd28cc81-1d5d-4119-b9fa-0e1e4e28f794">

---------

Co-authored-by: Igor Demin <igor.demin@jetbrains.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igordmn igordmn igordmn approved these changes

@Walingar Walingar Walingar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@MatkovIvan @igordmn @Walingar