Fix positioning of interop views. #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess it also fixes this? |
Very possible. |
dima-avdeev-jb
approved these changes
Dec 5, 2023
m-sasha
force-pushed
the
m-sasha/fix-interop-view-position
branch
from
1e7a94a
to
c5efdc0
Compare
mazunin-v-jb
pushed a commit
that referenced
this pull request
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
SwingPanelandUIKitViewused the "parent" coordinates, which ignores the last positioning modifier in the chain. Instead, just use the position of the current node.Testing
Test: Added a unit test
Issues Fixed
Fixes: JetBrains/compose-multiplatform#4005 and also the same problem with
UIKitView