Use binary search in SkiaParagraph.lineMetricsForOffset #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I changed |
MatkovIvan
reviewed
Dec 11, 2023
compose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/SkiaParagraph.skiko.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/MultiParagraph.kt
Outdated
Show resolved
Hide resolved
m-sasha
force-pushed
the
m-sasha/fast-lineMetricsForOffset
branch
from
44a40dc
to
f9dade7
Compare
MatkovIvan
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Use binary search in SkiaParagraph.lineMetricsForOffset. Currently the search is linear.
Testing
Test: Ran the user-provided reproducer. Also tested manually that caret is placed correctly when clicking in a multi-line textfield.
Issues Fixed
Fixes: JetBrains/compose-multiplatform#4021