Fix crash when DesktopInputService.methodRequestForInput() -> getTextLocation() is called #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Location() is called.
|
Not really sure why we haven't seen this crash before, as that function exists since 2020. Maybe it's rare for it to actually be called with |
igordmn
approved these changes
Jan 2, 2024
m-sasha
deleted the
m-sasha/fix-DesktopInputService-getTextLocation-nullability
branch
igordmn
reviewed
Jan 12, 2024
...se/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopPlatformInput.desktop.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JetBrains/compose-multiplatform#4115
The documentation of
InputMethodRequests.getTextLocationsays theoffsetargument can benull, but in our implementation of the interface it's marked as non-null. This causes the app to crash when actually called withnull:Proposed Changes
Mark the argument as nullable
Testing
Test: Nothing to test