Support select till the end of the file / till the start of the file keyboard actions on Windows #989
Conversation
| else -> defaultKeyMapping | ||
| else -> defaultSkikoKeyMapping |
There was a problem hiding this comment.
Shouldn't we just modify defaultKeyMapping in common?
There was a problem hiding this comment.
@MatkovIvan I'd ve glad to I just thought that this is less recommended because we need to merge back and to coordinate any changes - no matter how small - with google team.
There was a problem hiding this comment.
If the code is platform specific, better to keep it in our source set only.
If the code isn't platform specific - better to change it in commonMain and upstream.
Key mapping usually is platform specific, even if we have some default. We can't tell if it is needed for Android. defaultKeyMapping was added only because we didn't want to investigate platform behaviours.
| else -> defaultKeyMapping | ||
| else -> defaultSkikoKeyMapping |
There was a problem hiding this comment.
If the code is platform specific, better to keep it in our source set only.
If the code isn't platform specific - better to change it in commonMain and upstream.
Key mapping usually is platform specific, even if we have some default. We can't tell if it is needed for Android. defaultKeyMapping was added only because we didn't want to investigate platform behaviours.
...ion/foundation/src/desktopMain/kotlin/androidx/compose/foundation/text/KeyMapping.desktop.kt
Show resolved
Hide resolved
Schahen
changed the title
Schahen
changed the title
igordmn
changed the title
This PR is addressing following task
https://youtrack.jetbrains.com/issue/COMPOSE-784/Enable-selecting-till-the-end-of-the-file-till-the-beginning-of-the-file-in-Windows
(As of now, we do not support the standard way of selecting from current position till the end of the text / till the beginning of the text (that is - Shift / Ctrl / End and Shift / Ctrl / Home respectively) - but in MacOS we actually do. This goal of this task is to introduce such support)
Main changes are following:
defaultKeyMappingon. desktop (which can be done later on, it's just that we usually - this is at least my understanding - avoid intrusive changes to commonMain as the very first step if possible)