Add Arial and Consolas as backup fonts on Linux and mention font name when one fails to load #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharee
added a commit
to zacharee/SamloaderKotlin
that referenced
this pull request
Jan 16, 2024
…-core#994 is (hopefully) merged
zacharee
force-pushed
the
more-fallback-fonts-for-linux
branch
from
9edcf6e
to
c21736b
Compare
… when one fails to load.
zacharee
force-pushed
the
more-fallback-fonts-for-linux
branch
from
c21736b
to
a7fe61f
Compare
MatkovIvan
approved these changes
Jan 29, 2024
igordmn
approved these changes
Jan 29, 2024
MatkovIvan
added a commit
that referenced
this pull request
Jan 29, 2024
## Proposed Changes - Fixed build error after #994 ``` e: androidx/compose/ui/text/font/FontFamilyResolver.kt:261:5 Cannot find a parameter with this name: message e: androidx/compose/ui/text/font/FontFamilyResolver.kt:262:5 Cannot find a parameter with this name: cause ``` ## Testing Test: CI should handle it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
One of the users of my Compose Multiplatform app ran into an issue where the app immediately crashed on Arch saying "could not load font". I couldn't reproduce it, but when they asked for the fonts Compose is looking for and I started looking into it, I realized they might not have the right fonts installed. After they installed DejaVu Sans, the app opened as normal.
This PR does a few things:
Testing
Test: Get a Linux GUI up and running without Noto Sans or DejaVu Sans installed, but with Arial installed. Build a Compose sample app and it should run using Arial. Remove Arial and the error thrown should now be more descriptive.
Issues Fixed
N/A
Google CLA
Signed