New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for text decoration line styles via PlatformTextStyle #999
Conversation
e7dd699
to
e146058
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few things that break binary compatibility here. Please run ./gradlew desktopApiDump
to check this (and commit the updated dump)
...ose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/platform/SkiaParagraph.skiko.kt
Show resolved
Hide resolved
compose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/TextStyle.skiko.kt
Outdated
Show resolved
Hide resolved
…=DeprecationLevel.HIDDEN) and make new one private.
38a77db
to
2141d4d
Compare
@MatkovIvan @igordmn ping |
CI is failing, my previous comment is not resolved |
CI doesn't run. I don't know what to do about that. What isn't resolved? |
Proposed Changes
Skia already supports different text decoration (e.g. underline) styles (e.g. solid, dashed, dotted etc.), but we don't expose this.
This PR exposes it via
PlatformTextStyle
.Note that this isn't supported on Android.
Testing
Test: Manually.