Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktop: Can't type in TextField placed in ModalBottomSheet #3703

Closed
sdzshn3 opened this issue Sep 18, 2023 · 0 comments
Closed

Desktop: Can't type in TextField placed in ModalBottomSheet #3703

sdzshn3 opened this issue Sep 18, 2023 · 0 comments
Assignees
@MatkovIvan
Labels
bug Something isn't working desktop input Touch, mouse, keyboard input related

Comments

@sdzshn3
Copy link

sdzshn3 commented Sep 18, 2023 •
edited

Describe the bug
I'm not able to type text in OutlinedTextField which is placed inside ModalBottomSheet.

Affected platforms

  • Desktop

Versions

  • Kotlin version*: 1.9.0
  • Compose Multiplatform version*: 1.5.10-beta01
  • OS version(s)* (required for Desktop and iOS issues): macOS Ventura 13.5.2
  • OS architecture (x86 or arm64): x64

To Reproduce

  1. Create a composable function for content of bottom sheet.
  2. Have a stateless OutlinedTextField (get the value and onValueChange from function params and set them to OutlinedTextField)
  3. Call this function in ModalBottomSheet as it's content.
  4. Have the mutableState of string for TextField in same place where you trigger the bottomsheet to open.

Expected behavior
Should be able to type.
@sdzshn3 sdzshn3 added bug Something isn't working submitted labels Sep 18, 2023
@MatkovIvan MatkovIvan self-assigned this Sep 19, 2023
@MatkovIvan MatkovIvan mentioned this issue Sep 19, 2023
Merged
@MatkovIvan MatkovIvan added input Touch, mouse, keyboard input related desktop and removed submitted labels Sep 21, 2023
MatkovIvan added a commit to JetBrains/compose-multiplatform-core that referenced this issue Sep 21, 2023
@MatkovIvan
Fix ModalBottomSheetPopup parameters (#826)
955281b 
## Proposed Changes

- Position `ModalBottomSheet` not relative to parent
- Exclude default `Popup`'s insets

Before | After
--- | ---
<img
src="https://github.com/JetBrains/compose-multiplatform-core/assets/1836384/fe7b4b1b-8c12-49d7-9f4c-9c72af6d05cd"
height="600"> | <img
src="https://github.com/JetBrains/compose-multiplatform-core/assets/1836384/176a56ec-9469-4603-b0e8-153fa6c9318a"
height="600">

## Testing

Test: run mpp on iOS or try to use `ModalBottomSheetPopup` on device
with safe-area

## Issues Fixed

Fixes JetBrains/compose-multiplatform#3701,
JetBrains/compose-multiplatform#3703
igordmn pushed a commit to JetBrains/compose-multiplatform-core that referenced this issue Jan 30, 2024
@MatkovIvan @igordmn
Fix ModalBottomSheetPopup parameters (#826)
05b651b 
## Proposed Changes

- Position `ModalBottomSheet` not relative to parent
- Exclude default `Popup`'s insets

Before | After
--- | ---
<img
src="https://github.com/JetBrains/compose-multiplatform-core/assets/1836384/fe7b4b1b-8c12-49d7-9f4c-9c72af6d05cd"
height="600"> | <img
src="https://github.com/JetBrains/compose-multiplatform-core/assets/1836384/176a56ec-9469-4603-b0e8-153fa6c9318a"
height="600">

## Testing

Test: run mpp on iOS or try to use `ModalBottomSheetPopup` on device
with safe-area

## Issues Fixed

Fixes JetBrains/compose-multiplatform#3701,
JetBrains/compose-multiplatform#3703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MatkovIvan MatkovIvan

Labels
bug Something isn't working desktop input Touch, mouse, keyboard input related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MatkovIvan @sdzshn3