Crash on iOS: GrGpuResource::release()
#3862
Assignees
Labels
Comments
elijah-semyonov
added
rendering
|
Could be related to either skia upgrade or separate thread render commands encoding. Hard to figure out without reliable repro, I will have a closer look at it. |
elijah-semyonov
added
crash
p:high
|
We see this also, it should related to the pictures |
|
I believe this related to the oom issue on bitmaps, only crash on IOS, tried everything to stop the crash. |
|
I can provide lots of crash stack trace if that can help |
|
Happening to my app which is in production. Another trace |
elijah-semyonov
added a commit
to JetBrains/compose-multiplatform-core
that referenced
this issue
Nov 6, 2023
## Proposed Changes Since there are no reliable repros, it's a speculative fix for [the crash](JetBrains/compose-multiplatform#3862) on iOS. It's based on an assumption that the case for the crash is caused by render command encoding in a separate thread being performed after (or in parallel) with the context disposal on the main thread which leads to incorrect state inside Skia. ## Testing Test: see if issues persists. ## Issues Fixed Fixes: JetBrains/compose-multiplatform#3862 ## Note Skia is supposed to handle internal resources based on reference counting and assumed scenario shouldn't lead to the crash, since the context should be indirectly retained by the moment encoding starts. Revert if issue persists because that logic would be redundant.
|
@juhaodong @LaatonWalaBhoot @onseok Do your apps contain a lot of images? |
|
I will have to check about the |
|
|
@elijah-semyonov |
I appreciate the heads-up on the dev release. Regarding |
|
This information will also help:
Does the app have an image picker during which the app could be sent into background? |
|
I will add temporary experimental flag on incoming dev build: You can arbitrarily set |
|
@elijah-semyonov Another instance is after resuming app from the tray. Have used compose versions Will add the check in iOS source sets. There are different stack traces. Does that provide any info about what might be causing this? |
|
Thank you, it certainly adds some context to be used during further investigation. |
|
It would seem resuming view controllers might be the case. |
We are going to add support for fonts into our resource library next release
Do you mean this issue? |
|
Any tentative date for the next release with the fixes? |
It is a hard problem, we are investigating it right now. Currently we cannot provide estimations as it is still not clear what is the root cause. |
|
No worries. Thanks a lot for the help. For now, using the flag Eagerly waiting for the new release @pjBooms. Hopefully, UIKitView problems and resource library updates will be solved. |
By "single font flavor in the font family", do you mean only one font file? If So, I use only one and it crashes. I don't use MOKO also, instead, just raw |
|
@GuilhE |
|
Oh but this approach works for me, it stopped working properly starting from |
|
That's what the problem is. I am not sure when it started but it has been there since 1.5.1 |
|
We fixed Crash with fonts. Can you please check it without usage of flag But, if crash |
|
@dima-avdeev-jb |
|
@LaatonWalaBhoot Anyway, we want to fix all of it in next Compose |
|
@dima-avdeev-jb Stacktrace: |
|
I'm a bit late to the party but I encountered this issue after upgrading to |
|
@LaatonWalaBhoot Thanks so much for good assist in problem solving! Yeah, for now you can use Compose I am sure, that Compose As for white backgroud - not sure here. First of all we want to fix and publish as fast as possible all critical bugs. |
|
@ToluwaniO can please provide a minial reproducible sample of your problem on GitHub ? |
|
@dima-avdeev-jb |
|
@LaatonWalaBhoot |
|
@elijah-semyonov |
|
@LaatonWalaBhoot have not you tried the |
|
@pjBooms |
|
@pjBooms @elijah-semyonov |
elijah-semyonov
added a commit
to JetBrains/compose-multiplatform-core
that referenced
this issue
Nov 17, 2023
## Proposed Changes Using Skia context in multiple threads simultaneously leads to occasional unreproducable crashes on users' side. Roll back experimental #896. Disable the path for encoding rendering commands on a separate thread until the scenario is resolved and underlying issue is fixed. ## Testing Test: N/A ## Issues Fixed Fixes: JetBrains/compose-multiplatform#3862
igordmn
pushed a commit
to JetBrains/compose-multiplatform-core
that referenced
this issue
Nov 20, 2023
## Proposed Changes Using Skia context in multiple threads simultaneously leads to occasional unreproducable crashes on users' side. Roll back experimental #896. Disable the path for encoding rendering commands on a separate thread until the scenario is resolved and underlying issue is fixed. ## Testing Test: N/A ## Issues Fixed Fixes: JetBrains/compose-multiplatform#3862
mazunin-v-jb
pushed a commit
to JetBrains/compose-multiplatform-core
that referenced
this issue
Dec 7, 2023
## Proposed Changes Since there are no reliable repros, it's a speculative fix for [the crash](JetBrains/compose-multiplatform#3862) on iOS. It's based on an assumption that the case for the crash is caused by render command encoding in a separate thread being performed after (or in parallel) with the context disposal on the main thread which leads to incorrect state inside Skia. ## Testing Test: see if issues persists. ## Issues Fixed Fixes: JetBrains/compose-multiplatform#3862 ## Note Skia is supposed to handle internal resources based on reference counting and assumed scenario shouldn't lead to the crash, since the context should be indirectly retained by the moment encoding starts. Revert if issue persists because that logic would be redundant.
mazunin-v-jb
pushed a commit
to JetBrains/compose-multiplatform-core
that referenced
this issue
Dec 7, 2023
## Proposed Changes Using Skia context in multiple threads simultaneously leads to occasional unreproducable crashes on users' side. Roll back experimental #896. Disable the path for encoding rendering commands on a separate thread until the scenario is resolved and underlying issue is fixed. ## Testing Test: N/A ## Issues Fixed Fixes: JetBrains/compose-multiplatform#3862
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
We've received a handful of reports of crashes on iOS via the AppStore & Firebase Crashlytics. We have not yet been able to reproduce the crash ourselves.
Affected platforms
Select one of the platforms below:
Versions
To Reproduce
We don't have reproduction steps as of yet. We've seen a half-dozen of reports via the AppStore & Firebase Crashlytics.
Expected behavior
The app should not crash.
Screenshots
N/A
Additional context
The text was updated successfully, but these errors were encountered: