Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider support more targets for the KMP Lifecycle #4645

Closed
arkivanov opened this issue Apr 17, 2024 · 4 comments · Fixed by JetBrains/compose-multiplatform-core#1282
Closed

Consider support more targets for the KMP Lifecycle #4645

arkivanov opened this issue Apr 17, 2024 · 4 comments · Fixed by JetBrains/compose-multiplatform-core#1282
Assignees
@MatkovIvan
Labels
enhancement New feature or request

Comments

@arkivanov
Copy link
Contributor

As far as I can see, the KMP version of AndroidX Lifecycle with additional targets is now published to Maven Central. I would like to try using AndroidX Lifecycle in Decompose instead of the custom Lifecycle API. However, some targets required by Decompose are still not supported. Currently missing targets are: watchos, tvos, macos and linuxX64. Please consider publishing those targets as well. Thanks!
@arkivanov arkivanov added enhancement New feature or request submitted labels Apr 17, 2024
@arkivanov arkivanov mentioned this issue Apr 17, 2024
Open
@MatkovIvan MatkovIvan self-assigned this Apr 17, 2024
@MatkovIvan
Copy link
Member

macos and linuxX64 are there already - they use redirect to Google's binaries for available targets

Could you please specify what modules exactly you're interesting in? Asking because some modules from lifecycle group depend on Compose UI and could not be built for targets that not supported by Compose

@arkivanov
Copy link
Contributor Author

they use redirect to Google's binaries for available targets

Right, I missed that, thanks!

Could you please specify what modules exactly you're interesting in

I would need Lifecycle, LifecycleOwner and LifecycleRegistry. I believe that corresponds to lifecycle-common and lifecycle-runtime?

@MatkovIvan MatkovIvan mentioned this issue Apr 18, 2024
Merged
MatkovIvan added a commit to JetBrains/compose-multiplatform-core that referenced this issue Apr 18, 2024
@MatkovIvan
Publish additional targets for non-compose modules (#1282)
98eb014 
## Proposed Changes

- Add `watchos` and `tvos` to non-compose modules (lifecycle +
navigation)
- Add `mingwx64` for non-viewmodel modules

## Testing

Test: run `./gradlew :mpp:publishComposeJbToMavenLocal
-Pcompose.platforms=all`, verify result

## Issues Fixed

Fixes JetBrains/compose-multiplatform#4645
@hoc081098 hoc081098 mentioned this issue Apr 18, 2024
Open
@MatkovIvan
Copy link
Member

@arkivanov It's available in org.jetbrains.androidx.lifecycle:lifecycle-*:2.8.0-dev1590

@arkivanov
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MatkovIvan MatkovIvan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Publish additional targets for non-compose modules JetBrains/compose-multiplatform-core
2 participants
@MatkovIvan @arkivanov