Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resources library to dependencies declared by compose gradle plugin #2793

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

pjBooms
Copy link
Collaborator

@pjBooms pjBooms commented Feb 23, 2023

No description provided.

@pjBooms pjBooms requested a review from igordmn February 23, 2023 20:28
@@ -121,6 +121,7 @@ class ComposePlugin : Plugin<Project> {
val uiTooling get() = composeDependency("org.jetbrains.compose.ui:ui-tooling")
val preview get() = composeDependency("org.jetbrains.compose.ui:ui-tooling-preview")
val materialIconsExtended get() = composeDependency("org.jetbrains.compose.material:material-icons-extended")
val resources get() = composeDependency("org.jetbrains.compose.components:components-resources")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should move it to DesktopComponentsDependencies and add @ExperimentalComposeLibrary. We can't recommed it as a stable solution yet. We can move this functionality to compose-ui in the future (or just implicitly depend on it as a maven artifact)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add @ExperimentalComposeLibrar

Not sure though, but the rule was to add it for non-stable libraries so far :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should move it to DesktopComponentsDependencies

It is common dependency, why to move to desktop?

Copy link
Collaborator Author

@pjBooms pjBooms Feb 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to separate CommonComponentsDependencies so it can be referenced as compose.components.resources with @OptIn(org.jetbrains.compose.ExperimentalComposeLibrary::class)

@pjBooms pjBooms force-pushed the pjBooms/add-resource-library-dep branch from eb24755 to 78a94d5 Compare February 24, 2023 11:36
@pjBooms pjBooms merged commit 2cd92ee into master Feb 24, 2023
@pjBooms pjBooms deleted the pjBooms/add-resource-library-dep branch February 24, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants