Fix signing bundle with Gradle 8.1 with configuration cache #3069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compose Gradle plugin was launching `/usr/bin/security --find-identity` in a lazy property of AbstractJPackageTask. Without the configuration cache the computation was delayed to the execution phase. However, configuration cache serializes all properties of all configured tasks, so launching of `/usr/bin/security` shifted to the configuration phase. Gradle 8.1 started to throw an exception if an external process is launched during configuration time. This change explicitly moves the call to `/usr/bin/security` to the execution phase. Resolves #3060
dima-avdeev-jb
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compose Gradle plugin was launching
/usr/bin/security --find-identityin a lazy property of AbstractJPackageTask. Without the configuration cache the computation was delayed to the execution phase. However, configuration cache serializes all properties of all configured tasks, so launching of/usr/bin/securityshifted to the configuration phase.Gradle 8.1 started to throw an exception if an external process is launched during configuration time.
This change explicitly moves the call to
/usr/bin/securityto the execution phase.Resolves #3060