Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to notarytool #3330

Closed
wants to merge 2 commits into from

Conversation

DRSchlaubi
Copy link
Contributor

This is currently untested and is mainly to discuss the needed API changes.

I didn't forget about processUploadToolOutput and will update it, once I got to try it on a MAC and can take a look at the actual output

Fixes #3208

Copy link
Collaborator

@igordmn igordmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

discuss the needed API changes.

We should replace all properties for which we find a replacement, and deprecate others.

Let us know when the PR is ready for review.

@DRSchlaubi
Copy link
Contributor Author

Thanks!

discuss the needed API changes.

We should replace all properties for which we find a replacement, and deprecate others.

Let us know when the PR is ready for review.

You can review the API changes, those shouldn't change, it's just that I can't test the response parser yet

@igordmn
Copy link
Collaborator

igordmn commented Jul 11, 2023

The current API change ascProvider -> teamId looks good to me.

And if it is possible to keep ascProvider working, we should do that (now it throws an exception for existing usages).

Is it in the same format as the new parameter teamId?

@DRSchlaubi
Copy link
Contributor Author

The current API change ascProvider -> teamId looks good to me.

And if it is possible to keep ascProvider working, we should do that (now it throws an exception for existing usages).

Is it in the same format as the new parameter teamId?

Not at all if I understood the docs correctly, that's why I disabled it

@DRSchlaubi
Copy link
Contributor Author

DRSchlaubi commented Jul 11, 2023

According to the Apple documentation

TEAM_ID is your Team ID. You might be using the older --asc-provider or --asc-public-id options for this.

However, this man page says that --asc-provider expects a name, so no idea tbh

@igordmn
Copy link
Collaborator

igordmn commented Jul 13, 2023

If it is not possible to convert asc-provider to team-id, then an exception is fine.

@igordmn
Copy link
Collaborator

igordmn commented Jul 13, 2023

The alternative is still use altool if ascProvider is provided to give people seamless transition for a few months until it stops working in 11.2023

@DRSchlaubi
Copy link
Contributor Author

Is that really worth it? Most people probably don't use that option anyways and this will require adding two seperate implementations of the task to delay a change the have to do anyw

@igordmn
Copy link
Collaborator

igordmn commented Jul 13, 2023

Sounds reasonable, let's just throw an exception

@DRSchlaubi DRSchlaubi marked this pull request as ready for review July 17, 2023 09:16
@DRSchlaubi
Copy link
Contributor Author

Ig I need to update the tests as well

@DRSchlaubi
Copy link
Contributor Author

Superseded by #3642

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to notarytool
2 participants