-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to notarytool #3330
Migrate to notarytool #3330
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
discuss the needed API changes.
We should replace all properties for which we find a replacement, and deprecate others.
Let us know when the PR is ready for review.
You can review the API changes, those shouldn't change, it's just that I can't test the response parser yet |
The current API change ascProvider -> teamId looks good to me. And if it is possible to keep Is it in the same format as the new parameter teamId? |
Not at all if I understood the docs correctly, that's why I disabled it |
According to the Apple documentation
However, this man page says that --asc-provider expects a name, so no idea tbh |
If it is not possible to convert |
The alternative is still use |
Is that really worth it? Most people probably don't use that option anyways and this will require adding two seperate implementations of the task to delay a change the have to do anyw |
Sounds reasonable, let's just throw an exception |
Ig I need to update the tests as well |
Superseded by #3642 |
This is currently untested and is mainly to discuss the needed API changes.
I didn't forget about
processUploadToolOutput
and will update it, once I got to try it on a MAC and can take a look at the actual outputFixes #3208