Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cast to KotlinJvmTarget for all targets of type jvm #3592

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

AmrAfifiy
Copy link
Contributor

The new android multiplatform plugin will have type jvm but doesn't inherit from the KotlinJvmTarget type, which makes the compose multiplatform gradle plugin not useable with the new android gradle plugin for multiplatforms builds.

The new android multiplatform plugin will have type `jvm` but doesn't
inherit from the KotlinJvmTarget type, which makes the compose
multiplatform gradle plugin not useable with the new android gradle
plugin for multiplatforms builds.
@m-sasha
Copy link
Contributor

m-sasha commented Aug 31, 2023

Thanks for the PR, we'll look at it.

@AlexeyTsvetkov
Copy link
Collaborator

@AmrAfifiy do you have an example, where the issue could be reproduced? Generally LGTM, but I would like to add a test. I'm read to write the test myself, but I would like to clarify, what:

makes the compose multiplatform gradle plugin not useable with the new android gradle plugin for multiplatforms builds.

means

@jamesward
Copy link

Here is a fairly small reproducer: https://github.com/jamesward/hello-android/tree/compose-multiplatform

@AlexeyTsvetkov AlexeyTsvetkov merged commit 8799277 into JetBrains:master Sep 5, 2023
3 checks passed
@AlexeyTsvetkov
Copy link
Collaborator

@jamesward thanks for the reproducer!

I have checked the fix locally. The test will be added as a separate PR.

@AmrAfifiy thanks for the contribution!

@AmrAfifiy AmrAfifiy deleted the jvm-cast-removal branch September 5, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants