CfW: Allow web resource routing configuration #3852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the default resource routing behaviour: - It used to search for a file in the root directory (on a domain level) - After this change, it will search for a file relatively to the current url segment Besides that, we add a small configuration to let developers change the default behaviour when needed.
|
cc: @pjBooms Please have a look |
terrakok
reviewed
Oct 23, 2023
components/resources/library/src/jsMain/kotlin/org/jetbrains/compose/resources/Resource.js.kt
Outdated
Show resolved
Hide resolved
pjBooms
requested changes
Oct 24, 2023
components/resources/library/src/jsMain/kotlin/org/jetbrains/compose/resources/Resource.js.kt
Outdated
Show resolved
Hide resolved
pjBooms
approved these changes
Oct 24, 2023
terrakok
approved these changes
Oct 24, 2023
eymar
added a commit
that referenced
this pull request
Oct 24, 2023
This commit changes the default resource routing behaviour:
- It used to search for a file in the root directory (on a domain level)
- After this change, it will search for a file relatively to the current
url segment
Besides that, we add a small configuration to let developers change the
default behaviour when needed.
___
usage examples:
```kotlin
// 1
configureWebResources {
setResourceFactory { path -> urlResource("/myApp1/resources/$path") }
}
// 2
configureWebResources {
setResourcelFactory { path -> urlResource("https://mycdn.com/myApp1/res/$path") }
}
```
___
This will fix #3413 (currently it bothers our users)
(cherry picked from commit 7380229)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the default resource routing behaviour:
Besides that, we add a small configuration to let developers change the default behaviour when needed.
usage examples:
This will fix #3413 (currently it bothers our users)