Fix Compose Gradle plugin Issue with daemon in Issue 3933 #3951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dima-avdeev-jb
force-pushed
the
dima.avdeev/Fix-gradle-daemon-problem-in-issue-3933
branch
from
aebb563
to
0424b5e
Compare
pjBooms
approved these changes
Nov 24, 2023
dima-avdeev-jb
force-pushed
the
dima.avdeev/Fix-gradle-daemon-problem-in-issue-3933
branch
from
d386564
to
4ed1b24
Compare
|
|
|
We decided not cherry pick to 1.5.11 |
dima-avdeev-jb
deleted the
dima.avdeev/Fix-gradle-daemon-problem-in-issue-3933
branch
|
@dima-avdeev-jb So we should wait for 1.6.0 to make our build work? could you please share details regarding not cherry picking to 1.5.11. Thanks |
|
@dmitryskorbovenko Yes, you should wait 1.6.0 or use dev builds from here: https://github.com/JetBrains/compose-multiplatform/releases We decided to not cherry pick because of unsufficient amout of time to test new build artifacts. We was need to publish 1.5.11 with another critical bug fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Issue #3933
Applyed workaround described in Gradle Issue: gradle/gradle#27099
We just need to call all functions (getters in our case) in our interface based on BuildServiceParameters at least once