update ImageViewer build file #3956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eymar
added a commit
that referenced
this pull request
May 6, 2024
The intermediate `iosMain` source was previously removed here: #3956 And it worked fine. According to the doc https://kotlinlang.org/docs/whatsnew1920.html#set-up-the-target-hierarchy : > If you want to have additional source sets that the default hierarchy template doesn't provide, for example, one that shares code between a macOS and a JVM target, adjust the hierarchy by reapplying the template explicitly with applyDefaultHierarchyTemplate() and configuring additional source sets manually as usual with dependsOn() Now we have an additional custom source set named 'jsWasmMain', therefore we need to have `applyDefaultHierarchyTemplate()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I understood according to https://kotlinlang.org/docs/whatsnew1920.html#set-up-the-target-hierarchy those
dependsOncalls are no longer neededTested on iOS, MacOS and Android. It works as before