Resources gradle plugin #3961
Merged
Resources gradle plugin #3961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know why, but CI fails. Error: |
|
|
||
| internal fun Resource.getPathByEnvironment(): String { | ||
| //TODO |
There was a problem hiding this comment.
What this TODO means?
There was a problem hiding this comment.
Here will be a logic how to select a concrete file by an environment and qualifiers
gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/resources/ResourcesGenerator.kt
Outdated
Show resolved
Hide resolved
gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/resources/ResourcesGenerator.kt
Outdated
Show resolved
Hide resolved
dima-avdeev-jb
approved these changes
Nov 22, 2023
terrakok
force-pushed
the
res-gradle-plugin
branch
from
dda0451
to
54f2c05
Compare
|
👆 just rebased on the latest master |
pjBooms
requested changes
Nov 27, 2023
components/resources/library/src/commonMain/kotlin/org/jetbrains/compose/resources/Resource.kt
Show resolved
Hide resolved
...ts/resources/library/src/commonMain/kotlin/org/jetbrains/compose/resources/ImageResources.kt
Show resolved
Hide resolved
...s/resources/library/src/commonMain/kotlin/org/jetbrains/compose/resources/StringResources.kt
Show resolved
Hide resolved
...ts/resources/library/src/commonMain/kotlin/org/jetbrains/compose/resources/ImageResources.kt
Outdated
Show resolved
Hide resolved
...c/main/kotlin/org/jetbrains/compose/desktop/application/internal/ComposeProjectProperties.kt
Outdated
Show resolved
Hide resolved
| val dirs = rootResDir.listFiles { f -> f.isDirectory }.orEmpty() | ||
|
|
||
| //type -> id -> resource item | ||
| val resources: Map<ResourceType, Map<String, List<ResourceItem>>> = dirs |
There was a problem hiding this comment.
I would add some unit-tests for this logic
gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/resources/ResourcesGenerator.kt
Outdated
Show resolved
Hide resolved
And generate code only if there is a dependency on the resources library
…ources in the demo app
…esources.always.generate.accessors'.
…dle compilation warning
terrakok
force-pushed
the
res-gradle-plugin
branch
from
a510f07
to
7caa3c2
Compare
terrakok
force-pushed
the
res-gradle-plugin
branch
from
d2151d4
to
97c26c0
Compare
pjBooms
requested changes
Nov 30, 2023
gradle-plugins/compose/src/test/test-projects/misc/commonResources/expected/Res.kt
Show resolved
Hide resolved
terrakok
force-pushed
the
res-gradle-plugin
branch
from
b96d5e0
to
f9e7341
Compare
terrakok
force-pushed
the
res-gradle-plugin
branch
from
f9e7341
to
835bd7a
Compare
pjBooms
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.