Update for k/wasm #4009
Merged
Update for k/wasm #4009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eymar
commented
Dec 6, 2023
eymar
commented
Dec 6, 2023
eymar
commented
Dec 6, 2023
| @@ -77,25 +77,25 @@ class DesktopApplicationTest : GradlePluginTestBase() { | |||
| @Test | |||
| fun testSettingLatestCompiler() = testProject( | |||
| TestProjects.customCompiler, defaultTestEnvironment.copy( | |||
| kotlinVersion = "1.7.20", | |||
There was a problem hiding this comment.
Our compose-core is built using 1.9.21. Its metadata version is 1.9.x
Kotlin 1.7.x used in these tests failed with an error about medata version mismatch.
Therefore, I updated kotlin versions here.
eymar
commented
Dec 6, 2023
| @@ -12,16 +12,16 @@ import org.junit.jupiter.api.Test | |||
|
|
|||
| class KotlinCompatibilityTest : GradlePluginTestBase() { | |||
| @Test | |||
| fun testKotlinMpp_1_7_10() = testMpp("1.7.10") | |||
| fun testKotlinMpp_1_9_10() = testMpp("1.9.10") | |||
There was a problem hiding this comment.
older kotlin/js versions don't support libs build with 1.9.x, therefore an update here was necessary
eymar
commented
Dec 7, 2023
eymar
force-pushed
the
update_for_kwasm
branch
from
04269f2
to
7ccc50a
Compare
eymar
commented
Dec 8, 2023
...ins/compose/src/test/kotlin/org/jetbrains/compose/test/tests/integration/GradlePluginTest.kt
Show resolved
Hide resolved
…est/tests/integration/GradlePluginTest.kt
eymar
commented
Dec 8, 2023
...ins/compose/src/test/kotlin/org/jetbrains/compose/test/tests/integration/GradlePluginTest.kt
Show resolved
Hide resolved
…est/tests/integration/GradlePluginTest.kt
eymar
commented
Dec 8, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a comanion PR to JetBrains/compose-multiplatform-core#914
Resources lib doesn't contain k/wasm target yet. It will be added in a separate PR